-
Notifications
You must be signed in to change notification settings - Fork 795
[SYCL] Provide separate compilation support for free function kernels #18955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Provide separate compilation support for free function kernels #18955
Conversation
This reverts commit 34a11ca.
…com/lbushi25/llvm into free_functions_separate_compilation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good, left some nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming consts are either applied or not applicable.
Thanks, applied the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally nits and suggestions. LGTM!
@intel/llvm-gatekeepers This should be ready to merge! |
This PR adds separate compilation support for free function kernels.